Roll back google-apis-core for code-dot-org compatibility#9
Merged
cat5inthecradle merged 1 commit intomainfrom Dec 11, 2024
Merged
Roll back google-apis-core for code-dot-org compatibility#9cat5inthecradle merged 1 commit intomainfrom
cat5inthecradle merged 1 commit intomainfrom
Conversation
Hamms
approved these changes
Dec 11, 2024
Contributor
Hamms
left a comment
Hamms
left a comment
There was a problem hiding this comment.
LGTM!
Confirmed that all dependencies resolve as desired when installing directly from github:
diff --git a/Gemfile b/Gemfile
index 71e3b1354b2..0dd8e59df9e 100644
--- a/Gemfile
+++ b/Gemfile
@@ -63,7 +63,7 @@ gem 'rack-mini-profiler'
group :development do
gem 'annotate', '~> 3.1.1'
- gem 'aws-google', '~> 0.2.0'
+ gem 'aws-google', git: 'https://github.com/code-dot-org/aws-google', branch: 'darin/rollback-google-apis-core'
gem 'web-console', '~> 4.2.0'
# Bootsnap pre-caches Ruby require paths + bytecode and speeds up boot time significantly.
# We only use it in development atm to get a feel for it, and the benefit is greatest here.
Contributor
Author
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the 0.2.1 upgrade (#7), I also updated and pinned
google-apis-coreto the latest version, 0.15.1. This has a dependency ofgoogleauth1.9. However, over in the code-dot-org repository where we use this gem, we also use the oldgoogle_drivegem which requiresgoogleauth < 1.0This PR creates version 0.2.2 and rolls google-apis-core back to 0.11.3, the most recent version compatible with
googleauth < 1.0